[filesystem] Support AssumeRole STS for RustFS#2989
Open
fresh-borzoni wants to merge 2 commits intoapache:mainfrom
Open
[filesystem] Support AssumeRole STS for RustFS#2989fresh-borzoni wants to merge 2 commits intoapache:mainfrom
fresh-borzoni wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@leekeiabstraction @luoyuxia @wuchong |
1329a67 to
4351e0a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends Fluss’s S3 delegation-token acquisition to support RustFS/MinIO-style STS by allowing AssumeRole (instead of only GetSessionToken) and by supporting a configurable STS endpoint.
Changes:
- Add support for obtaining temporary credentials via
AssumeRolewhenfs.s3a.assumed.role.arnis configured. - Add support for using a custom STS endpoint via
fs.s3a.assumed.role.sts.endpoint. - Refactor STS client construction into a helper method.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ystems/fluss-fs-s3/src/main/java/org/apache/fluss/fs/s3/token/S3DelegationTokenProvider.java
Show resolved
Hide resolved
...ystems/fluss-fs-s3/src/main/java/org/apache/fluss/fs/s3/token/S3DelegationTokenProvider.java
Outdated
Show resolved
Hide resolved
...ystems/fluss-fs-s3/src/main/java/org/apache/fluss/fs/s3/token/S3DelegationTokenProvider.java
Show resolved
Hide resolved
...ystems/fluss-fs-s3/src/main/java/org/apache/fluss/fs/s3/token/S3DelegationTokenProvider.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Addressed Copilot comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #2661
Fix verified end-to-end against RustFS following #2569
for tiering setup you may consult this: lakekeeper/lakekeeper#1688 in order to make it work with iceberg and lakekeeper
Before fix:
After fix:
Config required for RustFS users:
Backward compatibility: