[client] Fix corruption after zero-copy lazy parse ByteBuf#3008
Open
fresh-borzoni wants to merge 1 commit intoapache:mainfrom
Open
[client] Fix corruption after zero-copy lazy parse ByteBuf#3008fresh-borzoni wants to merge 1 commit intoapache:mainfrom
fresh-borzoni wants to merge 1 commit intoapache:mainfrom
Conversation
This was referenced Apr 7, 2026
fresh-borzoni
force-pushed
the
fix-indexed-zero-copy-use-after-free
branch
2 times, most recently
from
44b9770 to
9ded936
Compare
fresh-borzoni
force-pushed
the
fix-indexed-zero-copy-use-after-free
branch
from
9ded936 to
b162d4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #2948, INDEXED/COMPACTED rows reference pooled Netty ByteBuf memory. When DefaultCompletedFetch.drain() releases the buffer, BinaryString fields in returned ScanRecords become dangling references — causing corruption like in https://github.com/apache/fluss/actions/runs/24007394419/job/70013234004?pr=3004
Fix: when building field getters for log record projection, defensively copy STRING/CHAR fields via BinaryString.copy() for formats that reference pooled buffers. ARROW is excluded since VectorizedColumnBatch already produces independent string copies.
The copy flag propagates through nested types (ARRAY, MAP, ROW) so structures like ARRAY are also safe.