Skip to content

[common] Deep copy BinaryString in createDeepFieldGetter to fix use-after-free #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YannByron wants to merge 1 commit into from
+6 −0
Closed

[common] Deep copy BinaryString in createDeepFieldGetter to fix use-after-free #3045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fluss-common/src/main/java/org/apache/fluss/row/InternalArray.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,9 @@ static ElementGetter createElementGetter(DataType fieldType) {
static ElementGetter createDeepElementGetter(DataType fieldType) {
final ElementGetter elementGetter;
switch (fieldType.getTypeRoot()) {
case STRING:
elementGetter = (array, pos) -> array.getString(pos).copy();
break;
case ARRAY:
DataType nestedType = ((ArrayType) fieldType).getElementType();
ElementGetter nestedGetter = createDeepElementGetter(nestedType);
Expand Down
3 changes: 3 additions & 0 deletions fluss-common/src/main/java/org/apache/fluss/row/InternalRow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,9 @@ static FieldGetter createFieldGetter(DataType fieldType, int fieldPos) {
static FieldGetter createDeepFieldGetter(DataType fieldType, int fieldPos) {
final FieldGetter fieldGetter;
switch (fieldType.getTypeRoot()) {
case STRING:
fieldGetter = row -> row.getString(fieldPos).copy();
break;
case ARRAY:
DataType elementType = ((ArrayType) fieldType).getElementType();
InternalArray.ElementGetter nestedGetter = createDeepElementGetter(elementType);
Expand Down