Skip to content

[helm] Add pod annotations, labels, and pod disruption budget support#3114

Merged
polyzos merged 2 commits intoapache:mainfrom
fresh-borzoni:feat/helm-pod-metadata-and-pdb
Apr 17, 2026
Merged

[helm] Add pod annotations, labels, and pod disruption budget support#3114
polyzos merged 2 commits intoapache:mainfrom
fresh-borzoni:feat/helm-pod-metadata-and-pdb

Conversation

@fresh-borzoni
Copy link
Copy Markdown
Contributor

@fresh-borzoni fresh-borzoni commented Apr 17, 2026

closes #3115

Production Kubernetes deployments commonly need custom pod annotations for integrations like Prometheus scraping or Vault agent injection, custom labels for service mesh routing and monitoring selectors, and PodDisruptionBudgets to prevent simultaneous eviction of tablet server replicas during node maintenance.

This PR adds all three as standard Helm chart fields for both coordinator and tablet server components, with PDB disabled by default.

@fresh-borzoni fresh-borzoni force-pushed the feat/helm-pod-metadata-and-pdb branch from 14e10cf to 850c4b2 Compare April 17, 2026 12:36
@fresh-borzoni
Copy link
Copy Markdown
Contributor Author

@affo @morazow @polyzos PTAL 🙏

Copy link
Copy Markdown
Contributor

@morazow morazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man @fresh-borzoni 🚀

I have added some comments and requests 🤝

Comment thread helm/templates/pdb-coordinator.yaml Outdated
Comment thread helm/templates/pdb-coordinator.yaml Outdated
Comment thread helm/tests/pod_metadata_and_pdb_test.yaml
Comment thread helm/templates/sts-coordinator.yaml
@fresh-borzoni
Copy link
Copy Markdown
Contributor Author

@morazow Ty for the nice review, addressed, PTAL 🙏

Copy link
Copy Markdown
Contributor

@morazow morazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🤝

Copy link
Copy Markdown
Contributor

@affo affo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another fundamental one, thanks @fresh-borzoni 🚀

@polyzos polyzos merged commit 845ced6 into apache:main Apr 17, 2026
3 checks passed
morazow pushed a commit to morazow/fluss that referenced this pull request Apr 23, 2026
…apache#3114)

* [helm] Add pod annotations, labels, and pod disruption budget support

* address feedback

(cherry picked from commit 845ced6)
polyzos pushed a commit that referenced this pull request Apr 23, 2026
…#3114) (#3185)

* [helm] Add pod annotations, labels, and pod disruption budget support

* address feedback

(cherry picked from commit 845ced6)

Co-authored-by: Anton Borisov <148864665+fresh-borzoni@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[helm] Add pod annotations, pod labels, and PodDisruptionBudget support

4 participants