[tiering] Fix Paimon IOManager leak in MergeTreeWriter#3190
Merged
luoyuxia merged 1 commit intoapache:mainfrom Apr 27, 2026
Merged
[tiering] Fix Paimon IOManager leak in MergeTreeWriter#3190luoyuxia merged 1 commit intoapache:mainfrom
luoyuxia merged 1 commit intoapache:mainfrom
Conversation
…isk exhaustion The IOManager created in MergeTreeWriter.createTableWrite() was passed inline to withIOManager() without keeping a reference. Since Paimon's TableWriteImpl does not own the IOManager lifecycle, it was never closed, leaving paimon-io-<UUID> directories in /tmp after each tiering task. This fix stores the IOManager as a field and explicitly closes it in close() via a finally block, ensuring temp directories are cleaned up. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix Paimon IOManager resource leak in
MergeTreeWriterthat causespaimon-io-<UUID>temp directories to accumulate in/tmpand eventually exhaust disk space when tiering service is running.Brief change log
The
IOManagercreated inMergeTreeWriter.createTableWrite()was passed inline towithIOManager()without keeping a reference. Since Paimon'sTableWriteImpldoes not own the IOManager lifecycle, the IOManager was never closed when the writer was closed, leavingpaimon-io-<UUID>directories behind in/tmpafter each tiering task.IOManageras a field inMergeTreeWriterclose()to explicitly close theIOManagerin a finally block, ensuring temp directories are cleaned up even iftableWrite.close()throwsTests
paimon-io-*directories in/tmpare cleaned up after writer closesAPI and Format
No API or storage format changes.
Documentation
No documentation changes needed.