Skip to content

[server] Add request queue size metric per processor #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zuston wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −5
Open

[server] Add request queue size metric per processor #3232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions fluss-rpc/src/main/java/org/apache/fluss/rpc/netty/server/RequestProcessorPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@
final class RequestProcessorPool {
private static final Logger LOG = LoggerFactory.getLogger(RequestProcessorPool.class);

private static final String PROCESSOR_INDEX = "processor_index";

private final RequestChannel[] requestChannels;
private final RequestProcessor[] processors;

Expand All @@ -54,10 +56,16 @@ public RequestProcessorPool(

RequestHandler<?>[] requestHandlers = initializeRequestHandlers(protocols, service);
for (int i = 0; i < numProcessors; i++) {
requestChannels[i] = new RequestChannel(totalQueueCapacity / numProcessors);
RequestChannel requestChannel = new RequestChannel(totalQueueCapacity / numProcessors);
requestChannels[i] = requestChannel;
// bind processor to a single channel to make requests from the
// same channel processed serializable
processors[i] = new RequestProcessor(i, requestChannels[i], service, requestHandlers);
processors[i] = new RequestProcessor(i, requestChannel, service, requestHandlers);
requestsMetrics.gauge(
PROCESSOR_INDEX,
String.valueOf(i),
MetricNames.REQUEST_QUEUE_SIZE,
requestChannel::requestsCount);
}
// register requestQueueSize metrics
requestsMetrics.gauge(MetricNames.REQUEST_QUEUE_SIZE, this::getRequestQueueSize);
Expand Down
5 changes: 5 additions & 0 deletions fluss-rpc/src/main/java/org/apache/fluss/rpc/netty/server/RequestsMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ <T, G extends Gauge<T>> void gauge(String name, G gauge) {
requestMetricGroup.gauge(name, gauge);
}

/** Create a gauge metric in a child group of the request metric group. */
<T, G extends Gauge<T>> void gauge(String groupKey, String groupValue, String name, G gauge) {
requestMetricGroup.addGroup(groupKey, groupValue).gauge(name, gauge);
}

/** Add a metric group for given request name. */
private void addMetrics(MetricGroup parentMetricGroup, String requestName) {
metricsByRequest.put(
Expand Down
18 changes: 15 additions & 3 deletions website/docs/maintenance/observability/monitor-metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,19 +639,31 @@ Some metrics might not be exposed when using other JVM implementations (e.g. IBM
</thead>
<tbody>
<tr>
<th rowspan="1"><strong>coordinator</strong></th>
<th rowspan="2"><strong>coordinator</strong></th>
<td rowspan="1">request</td>
<td>requestQueueSize</td>
<td>The CoordinatorServer node network waiting queue size.</td>
<td>Gauge</td>
</tr>
<tr>
<th rowspan="8">tabletserver</th>
<td rowspan="1">request_processor_index</td>
<td>requestQueueSize</td>
<td>The CoordinatorServer node network waiting queue size labeled with <code>processor_index</code>.</td>
<td>Gauge</td>
</tr>
<tr>
<th rowspan="9">tabletserver</th>
<td rowspan="1">request</td>
<td>requestQueueSize</td>
<td>The TabletServer node network waiting queue size.</td>
<td>Gauge</td>
</tr>
<tr>
<td rowspan="1">request_processor_index</td>
<td>requestQueueSize</td>
<td>The TabletServer node network waiting queue size labeled with <code>processor_index</code>.</td>
<td>Gauge</td>
</tr>
<tr>
<td rowspan="7">
request_produceLog
Expand Down Expand Up @@ -1172,4 +1184,4 @@ All metrics are registered under the `fluss.tieringService` metric group, which
<td>Meter</td>
</tr>
</tbody>
</table>
</table>
Loading