Skip to content

[test] Delete temp dir after cluster shutdown in FlussClusterExtension #3411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dream95 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

[test] Delete temp dir after cluster shutdown in FlussClusterExtension #3411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions fluss-server/src/test/java/org/apache/fluss/server/testutils/FlussClusterExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
import org.apache.fluss.server.zk.data.RemoteLogManifestHandle;
import org.apache.fluss.server.zk.data.TableAssignment;
import org.apache.fluss.server.zk.data.TableRegistration;
import org.apache.fluss.utils.FileUtils;
import org.apache.fluss.utils.clock.Clock;
import org.apache.fluss.utils.clock.SystemClock;

Expand Down Expand Up @@ -237,10 +238,6 @@ public void close() throws Exception {
rpcClient.close();
rpcClient = null;
}
if (tempDir != null) {
tempDir.delete();
tempDir = null;
}
for (TabletServer tabletServer : tabletServers.values()) {
tabletServer.close();
}
Expand All @@ -258,6 +255,10 @@ public void close() throws Exception {
zooKeeperServer.close();
zooKeeperServer = null;
}
if (tempDir != null) {
FileUtils.deleteDirectoryQuietly(tempDir);
tempDir = null;
}
}

/** Start a coordinator server. start a new one if no coordinator server exists. */
Expand Down