Skip to content

[tests] Fix FlinkSinkWriterTest.testSinkMetrics and FlinkMetricsITCase.testMetricsReport is unstable#552

Merged
wuchong merged 1 commit into
apache:mainfrom
wuchong:fix-sink-metrics
Mar 8, 2025
Merged

[tests] Fix FlinkSinkWriterTest.testSinkMetrics and FlinkMetricsITCase.testMetricsReport is unstable#552
wuchong merged 1 commit into
apache:mainfrom
wuchong:fix-sink-metrics

Conversation

@wuchong
Copy link
Copy Markdown
Member

@wuchong wuchong commented Mar 8, 2025

Purpose

Linked issue: close #549

The reason is the duration of ProduceLog RPC is too short and the sendLatencyInMs maybe small as 0 ms.

Brief change log

  1. change the default sendLatencyInMs to -1
  2. change the test comparison from isGreaterThan(0) to isGreaterThanOrEqualTo(0)

Tests

API and Format

Documentation

@wuchong wuchong requested a review from luoyuxia March 8, 2025 04:47
@wuchong wuchong merged commit c1804e8 into apache:main Mar 8, 2025
@wuchong wuchong deleted the fix-sink-metrics branch March 8, 2025 08:04
ZmmBigdata pushed a commit to ZmmBigdata/fluss that referenced this pull request Jun 20, 2025
Ugbot pushed a commit to Ugbot/fluss that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FlinkSinkWriterTest.testSinkMetrics is unstable

2 participants