[server] Fix CorruptIndexException for cached remote log index#652
Merged
Conversation
wuchong
reviewed
Mar 24, 2025
Member
wuchong
left a comment
wuchong
left a comment
There was a problem hiding this comment.
LGTM. Let's change CorruptIndexException extends to RuntimeException and move it server.excpetion module as
- it is not retriable
- it is only used in server, not registered in
Errors. - An
ApiExceptionremoves the exception stack which is hard to debug.
Contributor
Author
|
@wuchong Comments addressed |
wuchong
approved these changes
Mar 24, 2025
ZmmBigdata
pushed a commit
to ZmmBigdata/fluss
that referenced
this pull request
Jun 20, 2025
Ugbot
pushed a commit
to Ugbot/fluss
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #561
To fix the
CorruptIndexExceptionthrown by tablet server.Brief change log
Catch
CorruptIndexExceptionofRemoteLogIndexCache, and delete the corrupt index.Tests
RemoteLogIndexCacheTest#testInitWithCorruptIndexAPI and Format
Documentation