[Feature] Support for GenericArray && InternalArray interface#818
Closed
XuQianJin-Stars wants to merge 1 commit intoapache:mainfrom
Closed
[Feature] Support for GenericArray && InternalArray interface#818XuQianJin-Stars wants to merge 1 commit intoapache:mainfrom
XuQianJin-Stars wants to merge 1 commit intoapache:mainfrom
Conversation
XuQianJin-Stars
force-pushed
the
add-GenericArray
branch
3 times, most recently
from
d4a30e6 to
eb30655
Compare
XuQianJin-Stars
force-pushed
the
add-GenericArray
branch
from
2cb0af5 to
d34b329
Compare
XuQianJin-Stars
force-pushed
the
add-GenericArray
branch
from
ab7985f to
7e7c4df
Compare
Alibaba-HZY
reviewed
May 6, 2025
Contributor
There was a problem hiding this comment.
return a ColumnarArrayData implements ArrayData?Meanwhile this method com.alibaba.fluss.utils.ArrowUtils#createArrowFieldWriter also needs to be modified
Contributor
Author
There was a problem hiding this comment.
return a ColumnarArrayData implements ArrayData?Meanwhile this method com.alibaba.fluss.utils.ArrowUtils#createArrowFieldWriter also needs to be modified
I've already implemented the ColumnarArrayand ArrowUtils#createArrowFieldWriter in the subsequent PR.
Contributor
|
@XuQianJin-Stars could you share some context on why this PR is closed? Are you gonna introduce another one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: Support for GenericArray && InternalArray interface
Brief change log
InternalArrayinterfaceGenericArrayclassTests
GenericArrayTestAPI and Format
Documentation