Conversation
|
Hi @pjfanning , I just add a simple scala doc. It would be great if you can take a look at it. |
|
I did a quick test with Scala List and it looks like a lot of internal Scala classes are needed under the hood and they all need to be explicitly registered (unless you disable the need for registration). I can come back to this but it could take a while. I suspect that the list of Scala library classes that need to be registered is going to be very large. To make matters worse, Scala 2.13 rewrote a lot of Scala code relating to the collections - so the internal classes will be different from Scala 2.12. Any code to register a curated list of Scala library classes will need to try to register classes but move on if some of them fail. This could be a fair amount of work. |
|
That would be an issue. Registered should be stable across scala versions. Do we need to support registration check for some clas pattern such as scala.collection? |
|
It might be useful to support automated registration of every class in the |
|
Auto registration is a good idea. But The registered class will be written by an auto grown Id. the order can't be ensured across scala version if we support auto register unless we add a new inferface like register but write class as name still. |
|
Hi @pjfanning , do you think we should merge this pr now, or hold it until we have a more scala-native serialization support? There are some fury scala users already: #1029 |
|
It's fine to merge as is. |
What do these changes do?
add scala user doc
Related issue number
Closes #1024
Check code requirements