[Scala] add scala singleton object serializer#1053
Merged
chaokunyang merged 3 commits intoapache:mainfrom Oct 31, 2023
Merged
Conversation
Collaborator
Author
|
Hi @pjfanning , I implemented a SingletonObjectSerializer for scala |
Member
|
@chaokunyang I'm travelling at the moment. It's up to you but I'd recommend not adding this PR until it is possible to write automated Scala tests. I'm not volunteering to that - I'm very busy with other open source work. |
Collaborator
Author
I see, thanks. I'll hold this PR and try to setup a scala ci first. Happy travel, @pjfanning , thanks again for taking time at the travel. |
chaokunyang
force-pushed
the
add_optimized_scala_object_serializer
branch
from
2d496b5 to
60ee1e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR optimizes scala
objectserialization be special serializer. To avoid scala check overhead, this PPR introduce awithScalaOptimizationoption which is disabled by default. When this option is enabled,io.fury.serializer.scala.SingletonObjectSerializerwill be used forsingleton objectserialization.The
SingletonObjectSerializeris put into java source code since the implementation is simple.Complex scala integration will be put into
fury/scaladirectory instead.Related issue number
Closes #764
Check code requirements