Skip to content

rust/doc : add rust building#1129

Merged
theweipeng merged 4 commits intoapache:mainfrom
caicancai:rust_binding
Nov 23, 2023
Merged

rust/doc : add rust building#1129
theweipeng merged 4 commits intoapache:mainfrom
caicancai:rust_binding

Conversation

@caicancai
Copy link
Member

What do these changes do?

Related issue number

Closes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@caicancai
Copy link
Member Author

The DEVELOPMENT.md layout seems a little ugly, I will re-optimize it later

@chaokunyang
Copy link
Collaborator

@wangweipeng2 Could you help review this?

@caicancai caicancai requested a review from theweipeng November 22, 2023 13:30
Copy link
Member

@theweipeng theweipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@theweipeng theweipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caicancai "cd rust' is ok. The root directory is a cargo workspace, and cargo would automatically lookup the members."

@caicancai
Copy link
Member Author

caicancai commented Nov 23, 2023

a15a906b6bb1e373bca3f5625e2292f

cd rust, and then execute cargo test will give an error.
cd rust/fury will not report an error.
cc @chaokunyang

@caicancai caicancai requested a review from theweipeng November 23, 2023 03:48
@theweipeng
Copy link
Member

a15a906b6bb1e373bca3f5625e2292f cd rust, and then execute cargo test will give an error. cd rust/fury will not report an error. cc @chaokunyang

@caicancai
It should have been caused by my incorrect code the day before yesterday, so the error report is reasonable. I will fix it.

Copy link
Member

@theweipeng theweipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theweipeng theweipeng merged commit e1323ff into apache:main Nov 23, 2023
@caicancai caicancai deleted the rust_binding branch November 23, 2023 06:37
@chaokunyang
Copy link
Collaborator

a15a906b6bb1e373bca3f5625e2292f cd rust, and then execute cargo test will give an error. cd rust/fury will not report an error. cc @chaokunyang

Good catch, thanks for this, @caicancai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants