[Scala] Fix scala collection serialization nested in pojo#1140
Merged
theweipeng merged 1 commit intoapache:mainfrom Nov 24, 2023
Merged
[Scala] Fix scala collection serialization nested in pojo#1140theweipeng merged 1 commit intoapache:mainfrom
theweipeng merged 1 commit intoapache:mainfrom
Conversation
|
It is still failing if you pass an empty collection |
Collaborator
Author
|
@ghostdogpr I created a new issue for this bug in #1157, it will raise error too if you pass a singleton map object. This is uncommon in java, we missed this. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When a class contains a field of scala list/map type, fury will returna ReplaceResolver serializer if
io.fury.serializer.scala.ScalaDispatcheris not set, which will serializer CastException, since we assume all map/collection serializers all extendsAbstractMapSerializer/AbstractCollectionSerializerFix scala collection serialization nested in pojo
Related issue number
Closes #1137
Check code requirements