Skip to content

[C++] Remove useless fields and macro in logging#1195

Merged
chaokunyang merged 2 commits intoapache:mainfrom
PragmaTwice:logging
Dec 2, 2023
Merged

[C++] Remove useless fields and macro in logging#1195
chaokunyang merged 2 commits intoapache:mainfrom
PragmaTwice:logging

Conversation

@PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Dec 2, 2023

What do these changes do?

  • refactor some macros
  • move fury_severity_threshold to .cc
  • remove static local variables since it will bring locks
  • remove is_enabled_ field
  • we cannot use FURY_LOG inside GetLogLevel since fury_severity_threshold has not yet been initialized

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit 5eda45f into apache:main Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants