[C++] Support iterable types in RowEncodeTrait#1212
Merged
chaokunyang merged 1 commit intoapache:mainfrom Dec 6, 2023
Merged
Conversation
chaokunyang
approved these changes
Dec 6, 2023
Collaborator
chaokunyang
left a comment
There was a problem hiding this comment.
LGTM. one more thing, do we need to add an ArrayEncoder in array_encoder.h ?
Collaborator
|
Those meta programing codegen is really impressive, learned a lot from your code 😄 |
Member
Author
I plan to extend |
Collaborator
OK, got it |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In this PR we support any iterable types for
RowEncodeTraitand its combination with struct types, e.g.Check code requirements