Skip to content

[JavaScript] Implement the standard protocol#1286

Merged
theweipeng merged 4 commits intoapache:mainfrom
theweipeng:aligning_protocol
Jan 2, 2024
Merged

[JavaScript] Implement the standard protocol#1286
theweipeng merged 4 commits intoapache:mainfrom
theweipeng:aligning_protocol

Conversation

@theweipeng
Copy link
Member

  1. Make the tag string lazy to avoid creating strings.
  2. Add the serializeVolatile API to take ownership of the bufferWriter and avoid buffer copying, which is 30% faster than the serialize operation. There is a usage limitation; the bufferWriter remains inaccessible until the dispose method from the result of serializeVolatile has been called.
  3. Remove the useLatin1 configuration, which is a standard in the Fury protocol.

Before:
image

After:
image

2. add serializeVolatile api to avoid buffer copy which is 30% faster than serialize
3. remove the useLatin1 config which is standard in fury protocol
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theweipeng theweipeng merged commit 20f1849 into apache:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants