refactor(java): remove registerWithCheck function#1424
Merged
chaokunyang merged 3 commits intoapache:mainfrom Mar 25, 2024
LiangliangSui:sll_remove_registerWithCheck
Merged
refactor(java): remove registerWithCheck function#1424chaokunyang merged 3 commits intoapache:mainfrom LiangliangSui:sll_remove_registerWithCheck
chaokunyang merged 3 commits intoapache:mainfrom
LiangliangSui:sll_remove_registerWithCheck
Conversation
Remove `registerWithCheck` function and register function enables duplicate registration check by default. When Class is repeatedly registered, an `IllegalArgumentException` is thrown. Signed-off-by: LiangliangSui <coolsui.coding@gmail.com>
chaokunyang
reviewed
Mar 25, 2024
java/fury-core/src/main/java/org/apache/fury/resolver/ClassResolver.java
Show resolved
Hide resolved
Signed-off-by: LiangliangSui <coolsui.coding@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
registerWithCheckfunction and register function enables duplicate registration check by default. When Class is repeatedly registered, anIllegalArgumentExceptionis thrown.