-
Notifications
You must be signed in to change notification settings - Fork 340
chore(CI): Fix cache with symlinks #2893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Removed caching steps for Bazel binaries, repository, and build outputs.
Removed caching steps for Bazel binary, repository, and build outputs.
Removed caching steps for Bazel binaries, repository, and build outputs.
Collaborator
|
@prakash-218 maybe you could try setup-bazel cache later: now let me remove build cache to fix ci |
chaokunyang
approved these changes
Nov 5, 2025
chaokunyang
added a commit
to chaokunyang/fory
that referenced
this pull request
Nov 30, 2025
<!-- **Thanks for contributing to Apache Fory™.** **If this is your first time opening a PR on fory, you can refer to [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).** Contribution Checklist - The **Apache Fory™** community has requirements on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md). - Apache Fory™ has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here. --> ## Why? Bazel cache restoration was failing because symbolic links were being converted to regular files during cache save/restore operations. Added `enableCrossOsArchive: false` to all Bazel cache steps to preserve symlinks correctly. --------- Co-authored-by: Shawn Yang <chaokunyang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Why?
Bazel cache restoration was failing because symbolic links were being converted to regular files during cache save/restore operations.
Added
enableCrossOsArchive: falseto all Bazel cache steps to preserve symlinks correctly.