feat(c++): make fory enum/nuion macro in user namespace#3200
Merged
chaokunyang merged 10 commits intoapache:mainfrom Jan 26, 2026
Merged
feat(c++): make fory enum/nuion macro in user namespace#3200chaokunyang merged 10 commits intoapache:mainfrom
chaokunyang merged 10 commits intoapache:mainfrom
Conversation
urlyy
approved these changes
Jan 25, 2026
c00d160 to
8f1e8e2
Compare
8f1e8e2 to
b081c64
Compare
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Allow C++ enum/union/field metadata macros to live in user namespaces (no forced
fory::specialization) while keeping registration/serialization behavior consistent.What does this PR do?
UnionInfo(case ids, metas, factories).FORY_ENUMat namespace scope,FORY_STRUCTin public scope).FORY_JAVASCRIPT_JAVA_CI=0in the JavaScript xlang CI job.Related issues
#3099
#2906
#1017
Does this PR introduce any user-facing change?
C++ macro placement rules are now enforced via ADL-based descriptors; docs call out the required scope for
FORY_ENUM/FORY_STRUCT.Benchmark