feat(go): add missing type resolver for uint{16,32,64}slice #3311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaokunyang
reviewed
Feb 9, 2026
| "[]map[string][]map[string]*interface {}"}, | ||
| {reflect.TypeOf((*A)(nil)), "*@example.A"}, | ||
| {reflect.TypeOf((*A)(nil)).Elem(), "@example.A"}, | ||
| {reflect.TypeOf([]uint16{}), "[]uint16"}, |
Collaborator
There was a problem hiding this comment.
Could you also add a serialization test in go/fory/slice_primitive_test.go ?
Contributor
Author
There was a problem hiding this comment.
I'd be happy to. I'll add the tests for int/uint slice in a seperate PR.
Collaborator
There was a problem hiding this comment.
Could you add the tests in this PR? The fix should have coresponing tests in same PR
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. Because this PR only fixes the type_resolver, shouldn't the tests in go/fory/type_test.go be enough? I can also include the test for int8, int16, int32, int64 in type_test.go
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The
uintserializer and specificuint16,uint32,uint64slice serializers were implemented but missing from theTypeResolverregistration and dispatch logic. This causednot supportederrors when using these types.What does this PR do?
Type Registration:
uint16Type,uint32Type, anduint64TypeinnewTypeResolverinitialization to ensuredecodeTypecan correctly resolve these type strings.Serializer Dispatch:
createSerializerintype_resolver.goto correctly dispatch to the existing optimizeduint16SliceSerializer,uint32SliceSerializer, anduint64SliceSerializerfor the corresponding slice types.Tests:
TestTypeResolver(type_test.go) to verify that[]uint16,[]uint32, and[]uint64are correctly resolved and serialized.Related issues
Does this PR introduce any user-facing change?
Benchmark