fix(java): Fix EnumSetSerializer for enums with overriding methods#3315
Merged
chaokunyang merged 1 commit intoapache:mainfrom Feb 9, 2026
Merged
fix(java): Fix EnumSetSerializer for enums with overriding methods#3315chaokunyang merged 1 commit intoapache:mainfrom
chaokunyang merged 1 commit intoapache:mainfrom
Conversation
5339aa1 to
5de7511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Fix
EnumSetSerializersfor enums that have overriding methods in vairants:What does this PR do?
EnumSetSerializernow correctly unwraps types of variants that extend base enum type. Doing it this way instead of writing class of variant and unwrapping it in read prevents writing additional classes for enum variants.Related issues
Does this PR introduce any user-facing change?
This PR changes class of contained enum that
EnumSetSerializerwrites. Instead of writing class of enum variant if this variant extends base enum class it always writes class of base enum. This however does not break any existing code since previouslyEnumSets of classes with overriding methods could not be deserialized at allBenchmark