fix(c++): fix buffer read/write bound check#3418
Merged
chaokunyang merged 6 commits intoapache:mainfrom Feb 25, 2026
Merged
Conversation
urlyy
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
This PR hardens C++ and Rust deserialization paths against truncated/corrupt inputs and prevents inconsistent type registration state. It also enforces that xlang/non-xlang payloads are deserialized by matching protocol configs.
What does this PR do?
register_type(...).is_xlangflag differs from local config.TypeResolver::register_type_internalvalidate uniqueness before committing entries, so failed registrations do not leak partial type info.TypeMetasize handling andBuffervarint/fixed reads with strict bounds checks and non-advancing error behavior on truncated data.read_varuint36small.get(...)APIs returnResultinstead of panicking on out-of-bounds; propagate errors in map materialization.Related issues
Does this PR introduce any user-facing change?
Benchmark