fix(rust): handle panics from fuzz-found edge cases#3481
Merged
chaokunyang merged 1 commit intoapache:mainfrom Mar 15, 2026
Merged
Conversation
Cargo-fuzz was hitting several panics in the serialization code. Replace unwrap/unreachable with proper error handling: - field_id calculation now uses checked_add to catch overflows - field name decoding switched from unwrap() to Result propagation - byte_to_encoding now returns Result for unknown encoding bytes - MetaStringBytes::new() updated to return Result Closes apache#3480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3480
Cargo-fuzz was hitting several panics in the serialization code. Switched from unwrap/unreachable to proper error handling:
All of these return the same error type so the call sites already handle it correctly.
Why?
Fuzzing found inputs that triggered panics. Better to return an error than crash.
What does this PR do?
Replaces panics with proper error returns in the metadata serialization paths.
Related issues
#3480
AI Contribution Checklist
N/A
Does this PR introduce any user-facing change?
No. Valid inputs behave identically. Invalid/malformed data now returns an error instead of panicking.
Benchmark
N/A