Skip to content

fix(java): handle private final map codegen#3504

Merged
chaokunyang merged 1 commit intoapache:mainfrom
chaokunyang:issue-3503-private-final-map-codegen
Mar 24, 2026
Merged

fix(java): handle private final map codegen#3504
chaokunyang merged 1 commit intoapache:mainfrom
chaokunyang:issue-3503-private-final-map-codegen

Conversation

@chaokunyang
Copy link
Copy Markdown
Collaborator

@chaokunyang chaokunyang commented Mar 24, 2026

Why?

What does this PR do?

  • use a source-accessible local type when generated map chunk code handles monomorphic private final keys or values
  • keep serializer selection and wire behavior based on the declared private final type
  • add regression coverage for private final map keys and values under codegen with and without ref tracking

Related issues

Closes #3503

AI Contribution Checklist

  • Substantial AI assistance was used in this PR: yes / no
  • If yes, I included a completed AI Contribution Checklist in this PR description and the required AI Usage Disclosure.

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

@chaokunyang chaokunyang changed the title [Java] Fix map codegen for private final key/value types fix(java): handle private final map codegen Mar 24, 2026
@chaokunyang chaokunyang merged commit 4e94e97 into apache:main Mar 24, 2026
62 of 63 checks passed
@NotLebedev
Copy link
Copy Markdown
Contributor

Checked this patch and it fixed my original error. Thanks for quick fix 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Java] Incorrect codegen for Map with private final class keys/values

3 participants