fix(go): add configurable fieldCount and fieldDepth guardrails#3620
Merged
Conversation
Contributor
Author
|
@chaokunyang i'm planning to create these bounds configurable, moving them to the |
Contributor
Author
|
@chaokunyang have a look |
ayush00git
changed the title
chaokunyang
reviewed
Apr 27, 2026
| MaxCollectionSize: 1_000_000, | ||
| MaxBinarySize: 64 * 1024 * 1024, | ||
| MaxTypeDefFields: 10000, | ||
| MaxTypeDefDepth: 64, |
Collaborator
There was a problem hiding this comment.
You can reuse MaxDepth, we'd better to kepp config options minimal
chaokunyang
reviewed
Apr 27, 2026
| IsXlang: false, | ||
| MaxCollectionSize: 1_000_000, | ||
| MaxBinarySize: 64 * 1024 * 1024, | ||
| MaxTypeDefFields: 10000, |
Collaborator
There was a problem hiding this comment.
Suggested change
| MaxTypeDefFields: 10000, | |
| MaxTypeFields: 10000, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Malicious payloads could specify a massive
fieldCount, causing the runtime to attempt an unbounded memory allocation.Deeply nested schema definitions (like a LIST of LIST...) could trigger unbounded recursion, exceeding the goroutine stack limit and crashing the process.
What does this PR do?
Added a hard limit of 10,000 fields and a buffer-remaining check in decodeTypeDef to prevent massive slice allocations.
Added a depth parameter to
readFieldTypeandreadFieldTypeWithFlags, capping nested schema definitions at a maximum depth of 64.Related issues
Closes #3619
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Benchmark