fix(java): preserve externalizable containers in compatible mode#3628
Merged
chaokunyang merged 2 commits intoApr 28, 2026
Conversation
373ec21 to
54754d6
Compare
54754d6 to
39ef80e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Fory can lose entries for compatible-mode map and collection classes that implement
Externalizableif they are handled as ordinary containers instead of using their externalization logic.This fixes the data loss reported in #3621.
What does this PR do?
ExternalizableAbstractMapstored through aMap<String, String>field.Externalizablemap and collection implementations through the JDK-compatible serializer path.ExternalizableSerializersowriteExternal/readExternalpreserve their state.Related issues
AI Contribution Checklist
yesyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.AI Usage Disclosure
apache/main, where it fails withMaps do not have the same size:0 != 1.mvn -pl fory-core -Dtest=org.apache.fory.serializer.collection.MapSerializersTest#testExternalizableMapCompatibleMode test.mvn -T10 -B --no-transfer-progress spotless:check checkstyle:check,python ./ci/run_ci.py java --version 11,python ./ci/run_ci.py java --version 17,python ./ci/run_ci.py java --version 21,python ./ci/run_ci.py java --version 25,python ./ci/run_ci.py java --install-fory, andmvn -T10 --no-transfer-progress clean install -DskipTests -Dmaven.javadoc.skip=true -Dmaven.source.skip=true.Externalizablecontainer serializer selection in compatible mode, no benchmark runDoes this PR introduce any user-facing change?
Benchmark
Not run. This is a correctness fix for existing compatible-mode
Externalizablemap/collection handling and does not intentionally change public APIs or binary protocol format.