feat(csharp): support nested container field codec#3639
Merged
chaokunyang merged 1 commit intoapache:mainfrom Apr 29, 2026
Merged
Conversation
82dbfcc to
23ab3e1
Compare
pandalee99
approved these changes
Apr 29, 2026
23ab3e1 to
80abe8c
Compare
80abe8c to
97ce288
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
C# generated serializers need field-level schema descriptors that can describe the exact Fory wire type for scalars and nested containers. The previous
[Field(Encoding = ...)]model only handled a narrow integer-encoding override, which was not expressive enough for nested annotated container metadata or compatible-mode skipping based on remote field metadata.What does this PR do?
[Field]/FieldEncodingAPI with[ForyField], supporting optional stable field ids andType = typeof(S...)schema descriptors.Apache.Fory.Schema.Typesdescriptor marker types for scalar, packed-array, list, set, and map field metadata.[ForyField(Type = typeof(...))]hints, including nested map/list descriptors and reduced-precisionHalf/BFloat16carriers.CSharpXlangTest.[ForyField]descriptor API.Related issues
#1017
#3630
#3625
#3630
#3636
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Benchmark