fix(javascript): preserve getTypeInfo in regenerated read serializer#3669
Merged
Conversation
添加 getTypeInfo: serializer.getTypeInfo 到部分 serializer 对象, 防止反序列化时 getTypeInfo() 返回 undefined。
Collaborator
|
@xhzq233 Thanks for fix this. Could you add a test to cover it? |
…getTypeInfo Add a typemeta regression test that asserts regenerateReadSerializer returns an object exposing getTypeInfo for named structs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
@chaokunyang Thanks for the review. I have added a regression test in javascript/test/typemeta.test.ts:
Local verification command: npm --prefix javascript run test -- typemeta.test.ts And I also verified fail/pass behavior:
|
chaokunyang
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
TypeResolver.regenerateReadSerializer()returned a partial serializer object that missedgetTypeInfo.When runtime paths later call
original.getTypeInfo()(for example inReadContexttype-meta regeneration flow), it can throw:What does this PR do?
getTypeInfo: serializer.getTypeInfowhen registering the regenerated serializer injavascript/packages/core/lib/typeResolver.ts.Minimal reproduction:
Related issues
Fixes #3668
AI Contribution Checklist
noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Benchmark
N/A (bug fix, no protocol/perf-path behavior change expected).