feat(xlang): simplify xlang field ordering#3675
Merged
Merged
Conversation
pandalee99
approved these changes
May 13, 2026
90c04ed to
c3936b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The xlang field-ordering spec and several runtimes still treated non-primitive fields as separate type-specific groups. This PR simplifies the rule so non-primitive fields use one language-neutral identifier order, and makes invalid negative field ids fail early instead of being interpreted as name-based fields.
What does this PR do?
-1.Related issues
#1017
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Yes. Xlang non-primitive struct field ordering now follows field identifiers directly, and configured negative field ids are rejected. Fields without explicit ids continue to use name-based identifiers.
Benchmark
N/A