refactor(java): replace static serializer spi lookup#3680
Merged
chaokunyang merged 13 commits intoMay 14, 2026
Conversation
pandalee99
approved these changes
May 14, 2026
c8fafcf to
4ad7f95
Compare
5dda4f1 to
edeac19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Follow up to #3679: static generated serializer lookup no longer needs aggregate SPI provider classes or service resources. The runtime can resolve generated serializers from the registered target class name, which simplifies Java/Kotlin generation and makes Android/R8 packaging rely on generated keep rules instead of broad user-written service-loader rules.
What does this PR do?
StaticGeneratedSerializerProviderservice-loader discovery with registry lookup based on escaped generated serializer class names and required constructors.<target>_ForySerializer/<target>_ForyNativeSerializernames, emit per-targetMETA-INF/proguard/rules, and stop generating aggregate provider classes or service descriptors.@ForyStructclasses to generate internal serializers while keeping the constructor paths the Java runtime needs.TypeResolver, static generated serializer registry tests, Kotlin KSP validation tests, and Kotlin xlang coverage for the new discovery path.Related issues
#3679
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Benchmark
Not run; this PR changes static generated serializer lookup, generated metadata, docs, and tests rather than benchmarked serialization hot paths.