[JavaScript] detect platform wrong#832

Merged

theweipeng merged 1 commit intoapache:mainfrom

theweipeng:issue_757

Aug 2, 2023

Member

theweipeng commented Aug 2, 2023

What do these changes do?

The ECMA_ONLY environment variable is used to run unit tests in a browser environment, but the conditional statement was written incorrectly, causing it to be recognized as a browser environment in Node.js.
Add testcase for reader.ts

Related issue number

Check code requirements

tests added / passed (if needed)
Ensure all linting tests pass, see here for how to run them


          fix: add uint8 test

818f1eb

theweipeng self-assigned this

theweipeng merged commit 127517b into apache:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet