[Java] Optimize jdk9+ immutable collection serialization #900
Merged
chaokunyang merged 5 commits intoapache:mainfrom Sep 4, 2023
Merged
[Java] Optimize jdk9+ immutable collection serialization #900chaokunyang merged 5 commits intoapache:mainfrom
chaokunyang merged 5 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The jdk9+ immutable collection is not registered and optimized in fury.
Currently users need to register those class by fury.register(List.of(1,2).getClass()) for serialization, or disable class registration by
FuryBuilder.requireClassRegistration(false), which is tedious.More importantly , the serialization call writeReplace/readResolve to ensure jdk compatibilyty, which is not efficient.
And generics are not used either.
This PR optimize above all issues ,and support jit&generics optimization for such class.
.Related issue number
Closes #820
Check code requirements