Skip to content

GEODE-4066: Add security manager integration test#167

Merged
dgkimura merged 3 commits intoapache:developfrom
dgkimura:feature/GEODE-4066
Dec 12, 2017
Merged

GEODE-4066: Add security manager integration test#167
dgkimura merged 3 commits intoapache:developfrom
dgkimura:feature/GEODE-4066

Conversation

@dgkimura
Copy link
Member

@dgkimura dgkimura commented Dec 7, 2017

Integration test passed on Mac and Windows

Copy link
Contributor

@jake-at-work jake-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just replace the existing security tests with the configuration for security manager on the server? The old security model has been deprecated for some time. We are testing the security module on the server but rather the protocol between client and server which didn’t change: no point in validating the protocol for both server side modules.

@dgkimura dgkimura force-pushed the feature/GEODE-4066 branch 3 times, most recently from 5726301 to 6b88172 Compare December 12, 2017 03:09
@dgkimura
Copy link
Member Author

@pivotal-jbarrett I updated this pull-request to instead update existing security test testThinClientSecurityMultiUserTest.

While doing that I noticed another bug related to GEODE-3645 where stale cache is dereferenced. Testcase exposed some awkward code where we chained dereferences of cacheimpl to cache to cacheimpl. The change "GEODE-3645: Fix stale cache references" addresses this problem. If it helps readability/history I can move it to a separate pull-request.

@jake-at-work
Copy link
Contributor

@dgkimura Looks good, let's merge.

@dgkimura dgkimura merged commit 5ffe819 into apache:develop Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants