GEODE-5638: Use cmake to generate the SQLiteCLI plugin project into cli folder#365
Merged
mmartell merged 5 commits intoapache:developfrom Oct 3, 2018
Merged
Conversation
jake-at-work
requested changes
Oct 2, 2018
| # Set the .NET Target Framework (Note: This should match the build for Apache.Geode.) | ||
| set (DOTNET_TARGET_FRAMEWORK_VERSION "v4.5.2") | ||
|
|
||
| #foreach(var CMAKE_CURRENT_SOURCE_DIR CMAKE_SOURCE_DIR CMAKE_BINARY_DIR CMAKE_CURRENT_BINARY_DIR) |
Contributor
There was a problem hiding this comment.
Delete commented out code.
jake-at-work
requested changes
Oct 3, 2018
jake-at-work
reviewed
Oct 3, 2018
| VS_GLOBAL_TestProjectType UnitTest | ||
| VS_GLOBAL_PROJECT_TYPES "{3AC096D0-A1C2-E12C-1390-A8335801FDAB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION "v4.5.2" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION ${DOTNET_TARGET_FRAMEWORK_VERSION} |
Contributor
There was a problem hiding this comment.
Delete these since CMAKE_DOTNET_TARGET_FRAMEWORK_VERSION will handle the default.
| VS_GLOBAL_ROOTNAMESPACE ${PROJECT_NAME} | ||
| VS_GLOBAL_TreatWarningsAsErrors True | ||
| VS_GLOBAL_PROJECT_TYPES "{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION ${DOTNET_TARGET_FRAMEWORK_VERSION} |
| VS_GLOBAL_PROJECT_TYPES "{3AC096D0-A1C2-E12C-1390-A8335801FDAB};{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}" | ||
| VS_GLOBAL_ROOTNAMESPACE Apache.Geode.Test | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION "v4.5.2" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION ${DOTNET_TARGET_FRAMEWORK_VERSION} |
| VS_GLOBAL_TestProjectType UnitTest | ||
| VS_GLOBAL_PROJECT_TYPES "{3AC096D0-A1C2-E12C-1390-A8335801FDAB};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION "v4.5.2" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION ${DOTNET_TARGET_FRAMEWORK_VERSION} |
|
|
||
| # Set the .NET Target Framework (Note: This should match the build for Apache.Geode.) | ||
| set (DOTNET_TARGET_FRAMEWORK_VERSION "v4.5.2") | ||
| set (DOTNET_TARGET_FRAMEWORK_VERSION ${DOTNET_TARGET_FRAMEWORK_VERSION}) |
| VS_GLOBAL_TreatWarningsAsErrors True | ||
| VS_GLOBAL_PROJECT_TYPES "{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION "v4.5.2" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION ${DOTNET_TARGET_FRAMEWORK_VERSION} |
| VS_GLOBAL_PROJECT_TYPES "{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}" | ||
| VS_GLOBAL_ROOTNAMESPACE "Apache.Geode.Client.Tests" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION "v4.5.2" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION ${DOTNET_TARGET_FRAMEWORK_VERSION} |
| VS_GLOBAL_PROJECT_TYPES "{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}" | ||
| VS_GLOBAL_ROOTNAMESPACE "Apache.Geode.Client.Tests" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION "v4.5.2" | ||
| VS_DOTNET_TARGET_FRAMEWORK_VERSION ${DOTNET_TARGET_FRAMEWORK_VERSION} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.