GEODE-6012: Corrected package name in Dockerfile#395
Merged
jake-at-work merged 2 commits intoapache:developfrom Nov 9, 2018
Merged
GEODE-6012: Corrected package name in Dockerfile#395jake-at-work merged 2 commits intoapache:developfrom
jake-at-work merged 2 commits intoapache:developfrom
Conversation
- libc++api-dev (non-existent) changed to libc++abi-dev
jake-at-work
requested changes
Nov 7, 2018
docker/Dockerfile
Outdated
|
|
||
| FROM ubuntu | ||
| #FROM ubuntu | ||
| FROM ubuntu:16.04 |
Contributor
There was a problem hiding this comment.
Why lock this down to an older version of ubuntu?
Author
There was a problem hiding this comment.
That's a mistake, leftover from testing on 16.04. I've pushed the change and payed attention, this time.
jake-at-work
approved these changes
Nov 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker image successfully builds and geode-native is able to be built on resulting image.