Skip to content

GEODE-4337: Correct Path Searching in FindGeode module#396

Merged
pdxcodemonkey merged 1 commit intoapache:developfrom
pdxcodemonkey:GEODE-4337-fix-build-break
Nov 7, 2018
Merged

GEODE-4337: Correct Path Searching in FindGeode module#396
pdxcodemonkey merged 1 commit intoapache:developfrom
pdxcodemonkey:GEODE-4337-fix-build-break

Conversation

@pdxcodemonkey
Copy link
Copy Markdown
Contributor

@pdxcodemonkey pdxcodemonkey commented Nov 7, 2018

  • Function execution example includes a jar, so we need Geode to build the java code
  • Geode find module problem was breaking build of examples. It was setting the 'hints' variable to the value of GEODE_ROOT, which only works if the 'paths' parameter to find_package_handle_standard_args is empty, but it was always setting paths. Switched it to set one or the other like the FindGeodeNative find module does, and all is better.

Co-authored-by: Matthew Reddington mreddington@pivotal.io

- Geode find module problem was breaking build of examples

Co-authored-by: Matthew Reddington <mreddington@pivotal.io>
@igodwin igodwin changed the title Fix build break associated with change for GEODE-4337 GEODE-4337: Fix build break Nov 7, 2018
Copy link
Copy Markdown

@igodwin igodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Copy Markdown
Contributor

@jake-at-work jake-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better commit message please.

@pdxcodemonkey pdxcodemonkey changed the title GEODE-4337: Fix build break GEODE-4337: Correct Path Searching in FindGeode module Nov 7, 2018
@pdxcodemonkey pdxcodemonkey merged commit 9df8f88 into apache:develop Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants