Skip to content

Conversation

@pdxcodemonkey
Copy link
Contributor

... and rename it "ExpirationTest," since it doesn't actually use/test AttributeMutator.

Blake Bender and others added 4 commits January 7, 2019 10:25
…updating old code

Co-authored-by: Michael Oleske <moleske@pivotal.io>
Co-authored-by: Michael Oleske <moleske@pivotal.io>
…test AttributesMutator

Co-authored-by: Michael Oleske <moleske@pivotal.io>
- not necessary to create a server to run this test
@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #431 into develop will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #431      +/-   ##
==========================================
+ Coverage    72.17%   72.3%   +0.13%     
==========================================
  Files          655     654       -1     
  Lines        52380   52349      -31     
==========================================
+ Hits         37803   37851      +48     
+ Misses       14577   14498      -79
Impacted Files Coverage Δ
cppcache/src/ThinClientLocatorHelper.cpp 73.98% <0%> (+0.4%) ⬆️
cppcache/src/ThinClientRegion.cpp 55.65% <0%> (+0.45%) ⬆️
cppcache/src/ThinClientRedundancyManager.cpp 72.5% <0%> (+0.46%) ⬆️
cppcache/src/ClientMetadata.cpp 62.96% <0%> (+0.61%) ⬆️
cppcache/src/TcrEndpoint.cpp 53.19% <0%> (+0.83%) ⬆️
cppcache/src/ThinClientPoolDM.cpp 68.76% <0%> (+0.96%) ⬆️
cppcache/src/statistics/HostStatSampler.cpp 47.15% <0%> (+1.03%) ⬆️
cppcache/src/RemoteQuery.cpp 76.84% <0%> (+1.05%) ⬆️
cppcache/include/geode/ExceptionTypes.hpp 35.16% <0%> (+1.09%) ⬆️
cppcache/src/TcrConnection.cpp 63.31% <0%> (+1.13%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a816ac9...6279c9a. Read the comment docs.

Copy link

@igodwin igodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean port. I appreciate the rename. Perhaps, if we decide to create a single test suite for all region attributes, we could name it more generic, again. attributesMutator was refactored to attributes in a past PR, but it looks like we didn't update the test name.

@pdxcodemonkey
Copy link
Contributor Author

Yeah we'll need to check and see if we have coverage of attributes elsewhere, cause this test definitely did/does nothing the original name would suggest.

@pdxcodemonkey pdxcodemonkey merged commit adf1df6 into apache:develop Jan 11, 2019
@pdxcodemonkey pdxcodemonkey deleted the GEODE-6249-port-attributes-mutator-test branch January 11, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants