Skip to content

GEODE-6054: Move Windows CI workers to Server 2016 and VS 2017#439

Merged
pdxcodemonkey merged 35 commits intoapache:developfrom
igodwin:GEODE-6054-windows-2016-vs-2017
Jan 28, 2019
Merged

GEODE-6054: Move Windows CI workers to Server 2016 and VS 2017#439
pdxcodemonkey merged 35 commits intoapache:developfrom
igodwin:GEODE-6054-windows-2016-vs-2017

Conversation

@igodwin
Copy link
Copy Markdown

@igodwin igodwin commented Jan 26, 2019

Windows CI workers have been updated to the latest Windows Server 2016 release, and now use Visual Studio 2017 for builds. A lot of work done to get the latest version of openssh (from Chocolatey) to work on Server 2016, as well as migrate EC2 initialization and cleanup scripts to work with current methods.

Ernie and others added 30 commits January 24, 2019 10:00
Co-authored-by: Ernest Burghardt <eburghardt@pivotal.io>
Co-authored-by: Ernest Burghardt <eburghardt@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Ernie Burghardt <eburghardt@pivotal.io>
Co-authored-by: Jake Barrett <jbarrett@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Matt Reddington <mreddington@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Ernie Burghardt <eburghardt@pivotal.io>
Co-authored-by: Jake Barrett <jbarrett@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Ernie Burghardt <eburghardt@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Ernie Burghardt <eburghardt@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Ernie Burghardt <eburghardt@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Ernie Burghardt <eburghardt@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Jake Barrett <jbarrett@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Jake Barrett <jbarrett@pivotal.io>
- increase instance root volume size to 100GB

Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Jake Barrett <jbarrett@pivotal.io>
… image

Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Jake Barrett <jbarrett@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Jake Barrett <jbarrett@pivotal.io>
…p script where missing

Co-authored-by: Jacob Barrett <jbarrett@pivotal.io>
Co-authored-by: Ivan Godwin <igodwin@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Jake Barrett <jbarrett@pivotal.io>
Ivan Godwin and others added 5 commits January 25, 2019 18:35
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
- add 60s delay before install-dependencies

Co-authored-by: Mike Martell <mmartell@pivotal.io>
- initialize scripts added to each stage
@moleske
Copy link
Copy Markdown
Member

moleske commented Jan 26, 2019

I don't see any readme/building dot md changes, is that something that needs updating also?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 26, 2019

Codecov Report

Merging #439 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #439      +/-   ##
===========================================
+ Coverage    72.23%   72.26%   +0.03%     
===========================================
  Files          654      654              
  Lines        52351    52351              
===========================================
+ Hits         37814    37830      +16     
+ Misses       14537    14521      -16
Impacted Files Coverage Δ
cppcache/src/ThinClientRegion.cpp 55.7% <0%> (-0.46%) ⬇️
cppcache/src/ThinClientPoolDM.cpp 67.63% <0%> (+0.06%) ⬆️
cppcache/src/ThinClientLocatorHelper.cpp 73.98% <0%> (+0.4%) ⬆️
cppcache/src/ClientMetadataService.cpp 59.18% <0%> (+0.45%) ⬆️
cppcache/src/ThinClientRedundancyManager.cpp 72.5% <0%> (+0.46%) ⬆️
cppcache/src/TcrEndpoint.cpp 53.19% <0%> (+0.83%) ⬆️
cppcache/src/TcrConnection.cpp 63.31% <0%> (+1.13%) ⬆️
cppcache/src/TcrPoolEndPoint.cpp 86.48% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dae2c1...35e0d72. Read the comment docs.

@pdxcodemonkey pdxcodemonkey merged commit 587abeb into apache:develop Jan 28, 2019
pdxcodemonkey pushed a commit that referenced this pull request Feb 11, 2019
* Build with Visual Studio 2017 runtime.
* Fix up VS2015 dependencies in 3rd-party OSS
* Add 2017 provisioner file
* Use default version of OpenSSH
* Added script to fix ssh-user permissions
* Swith from choco to vs bootstrapper
* Execute Repair-AuthorizedKeyPermission on boot
* Fixed path to OpenSSHUtils
* Wait for install to finish, before exit
* Merging init-ssh and install-ssh to avoid permission issues
* Point to proper vcvarsall.bat location
* added windows 10 sdk to package ids
* Mark ThinClientPoolTestsN as FLAKY
* Up SSD size for build-windows AMI, to agree with new base image
* GEODE-6054: Run EC2Launch script at end of packer scripts, add cleanup script where missing
* installing .NET 3.5 for nunit
* Add component IDs for VisualStudio2017 install
* Use two part install of visual studio
* Switch to direct aka download of vs bootstrapper
* GEODE-6054: Replace EC2Config with EC2Launch in base AMI step
* Refactor initialization process
* add 60s delay before install-dependencies

Co-authored-by: Ivan Godwin <igodwin@pivotal.io>
Co-authored-by: Mike Martell <mmartell@pivotal.io>
Co-authored-by: Ernie Burghardt <eburghardt@pivotal.io>
Co-authored-by: Jake Barrett <jbarrett@pivotal.io>
Co-authored-by: Matt Reddington <mreddington@pivotal.io>
@igodwin igodwin deleted the GEODE-6054-windows-2016-vs-2017 branch March 13, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants