GEODE-7303: Simplify native client UG builds#538
Merged
davebarnes97 merged 1 commit intoapache:developfrom Oct 18, 2019
Merged
Conversation
Contributor
alb3rtobr
commented
Oct 17, 2019
alb3rtobr
commented
- Now each user guide has its separated book directory, removing the current need of patching two files depending on the user guide being generated.
- The docker-based solution of GEODE-7272 has been adapted to each user guide, so they can be built just running a script.
- Now each user guide has its separated book directory - The docker-based solution of GEODE-7272 has been applied to each user guide
Contributor
davebarnes97
left a comment
davebarnes97
left a comment
There was a problem hiding this comment.
@alb3rtobr You caught me by surprise - I was just about to submit a PR on this myself. Yours looks very interesting, and includes Docker work that I had not done. Give me a little time to compare our solutions. Thanks!
Contributor
|
+1 for the separate book directories Nice work! |
davebarnes97
approved these changes
Oct 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.