GEODE-7447: Fix logging format spec <--> variable size mismatches#548
Merged
pdxcodemonkey merged 5 commits intoapache:developfrom Nov 15, 2019
Merged
Conversation
Contributor
pdxcodemonkey
commented
Nov 13, 2019
pdxcodemonkey
commented
- std::chrono 'Rep' type changes size based on platform
- when size mismatched to format spec in log call, bad things happen
added 2 commits
November 13, 2019 10:19
- std::chrono 'Rep' type changes size based on platform - when size mismatched to format spec in log call, bad things happen
Contributor
Author
Contributor
Author
|
This has issues, closing PR for now while I diagnose |
added 2 commits
November 13, 2019 23:24
Co-authored-by Michael Oleske <moleske@pivotal.io>
- also fix up any other discrepancies found between sizeof(type) and %z format specifier
moleske
approved these changes
Nov 15, 2019
Member
moleske
left a comment
moleske
left a comment
There was a problem hiding this comment.
Glad you were able to track down all those %zs! Lesson learned from fixing those LGTM issues
moleske
approved these changes
Nov 15, 2019
Member
moleske
left a comment
moleske
left a comment
There was a problem hiding this comment.
whoops, glad you caught those to_strings so we can get the units labeled properly!
pdxcodemonkey
pushed a commit
to pdxcodemonkey/geode-native
that referenced
this pull request
Nov 26, 2019
…ache#548) * GEODE-7447: Fix logging format spec <--> variable size mismatches - std::chrono 'Rep' type changes size based on platform - when size mismatched to format spec in log call, bad things happen - also fix up any other discrepancies found between sizeof(type) and %z format specifier - Switch calls to our to_string implementation for durations (cherry picked from commit a88247f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.