Update C++ serialization example#617
Merged
davebarnes97 merged 2 commits intoapache:developfrom Jun 15, 2020
Merged
Conversation
karensmolermiller
approved these changes
Jun 11, 2020
karensmolermiller
left a comment
karensmolermiller
left a comment
There was a problem hiding this comment.
Looks fine to me. I made one suggestion for wording change, but it is up to you whether you implement the change.
| The fields that are marked as identity fields are used to generate the `hashCode` and equality | ||
| methods of PdxInstance. Because of this, the identity fields should themselves either be primitives, | ||
| or implement `hashCode` and equals. The identity fields should be marked after they are written | ||
| using a `write*` method. |
There was a problem hiding this comment.
Line 85-86, I'd prefer to see a different wording that directly states that we are ordering the function calls. Perhaps something like:
"Invoke the markIdentityField function directly following its write* function.
I would do the same as surrounding prose, but I think of C++ as having functions, while Java has methods. Probably no one cares which term you use.
Contributor
Author
There was a problem hiding this comment.
Good suggestions, @karensmolermiller. I checked in a revision - please give it a second look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.