GEODE-9608: NetCore projects should be compiled with Warnings as Error #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-at-work
approved these changes
Oct 4, 2021
davebarnes97
pushed a commit
to davebarnes97/geode-native
that referenced
this pull request
Feb 9, 2022
davebarnes97
pushed a commit
to davebarnes97/geode-native
that referenced
this pull request
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NetCore projects should be compiled with Warnings as Errors to be consistent with other geode-native components. Also, some of the projects are missing RelWithDebInfo configuration.
Remove Release config, add Optimization and pdb