GEODE-4007: Authentication/Handshake errors should close the socket#1087
Merged
upthewaterspout merged 1 commit intoapache:developfrom Dec 6, 2017
Merged
GEODE-4007: Authentication/Handshake errors should close the socket#1087upthewaterspout merged 1 commit intoapache:developfrom
upthewaterspout merged 1 commit intoapache:developfrom
Conversation
PivotalSarge
approved these changes
Nov 22, 2017
| Result<Resp, ErrorResp> process(SerializationService serializationService, Req request, | ||
| MessageExecutionContext messageExecutionContext) throws InvalidExecutionContextException; | ||
| MessageExecutionContext messageExecutionContext) | ||
| throws InvalidExecutionContextException, ConnectionStateException; |
Contributor
There was a problem hiding this comment.
Is ConnectionStateException still thrown? Or is the throws just inherited from ConnectionStateProcessor?
Author
There was a problem hiding this comment.
ConnectionStateException is newly thrown in this change, Galen made the observation that the code we're using to handle this inside the OpHandler is identical to the catch code we're using in the function calling this.
This will cause the connection to be closed whenever a handshake or authentication message fails. The connection will also be broken if we ever receive an unexpected handshake or authenticantication message. Signed-off-by: Galen O'Sullivan <gosullivan@pivotal.io>
WireBaron
force-pushed
the
feature/GEODE-4007
branch
from
05ba3f3 to
e701484
Compare
Author
|
Also force pushed a new version with some commits that were missed. |
upthewaterspout
approved these changes
Dec 6, 2017
Contributor
upthewaterspout
left a comment
upthewaterspout
left a comment
There was a problem hiding this comment.
+1 I'll merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@PivotalSarge @galen-pivotal @bschuchardt @upthewaterspout
This will cause the connection to be closed whenever a handshake or
authentication message fails.
The connection will also be broken if we ever receive an unexpected handshake or
authenticantication message.
Signed-off-by: Brian Rowe browe@pivotal.io
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.