GEODE-3063 partition resolver doc revisions#1105
Conversation
There was a problem hiding this comment.
Nice work! I have one question about verbiage you inherited. Each of the three sections describing a type of partitioning (fixed, custom, standard) begins with "By default <product> partitions each data entry into a bucket..." Is "partitions into" the right verb here? I'm thinking partitioning is for regions, so for data items "maps into" or "assigns to" might be better. Your call.
|
Here are Darrel's comments on this PR: I think it is confusing to abbreviate : "standard custom partitioning" by dropping "custom" from it. So I would say we should include "custom" in both "standard partitioning" and "fixed partitioning". change: "Using a custom class." change: "Specify this class as the partition resolver during region creation." change: "For keys implemented as objects, define the interface within the key’s class." change: "Using the cache callback class." change: "Implement the interface within a cache callback’s class." change: "Implementing the String-Based Partition Resolver" In the section titled "Configuring Standard Partitioning" change the title to "Configuring the Partition Resolver Region Attribute" Delete these items from the configuration section: Delete this line: Define the class for the region at creation. The resolver will be used for every entry operation. Use one of these methods: |
* GEODE-3063 partition resolver doc revisions * GEODE-3063: Revisions on docs of custom partitioning
My previous PR for this work has been closed. This PR now contains a single commit for the entire change set. The sections on partition resolvers have been completely rewritten and reorganized. All review comments in the previous PR and in the Geode JIRA (GEODE-3063) have been addressed.
Please review/re-review this new PR.