GEODE-3976: improve exception message#1146
Merged
dschneider-pivotal merged 1 commit intoapache:developfrom Dec 11, 2017
Merged
Conversation
dschneider-pivotal
requested review from
agingade,
kirklund,
lgallinat and
nreich
nreich
approved these changes
Dec 8, 2017
lgallinat
approved these changes
Dec 8, 2017
|
Need to run spotless to cleanup formatting, but is otherwise good to go. |
The message in the exception thrown when the disk monitor detects we have gone critical (i.e. run out of space) will now also tell why it went critical. It will either say something like this: the file system is 2 percent full, which exceeds the critical threshold of 1.9 percent. or something like this: the file system only has 98 bytes free which is below the minimum of 1048576. Also added unit test for DiskUsage class.
dschneider-pivotal
force-pushed
the
feature/GEODE-3976
branch
from
dc39c66 to
eee9b2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message in the exception thrown when the disk monitor
detects we have gone critical (i.e. run out of space) will
now also tell why it went critical.
It will either say something like this:
the file system is 2% full, which exceeds the critical threshold of 1.9%.
or something like this:
the file system only has 98 bytes free which is below the minimum of 1048576.
Also added unit test for DiskUsage class.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.