Conversation
While code review found that the refactoring moved "evictionNode.unsetRecentlyUsed()" to "appendEntry()" which gets call by other places (adding entry into the list); this causes the recently used entry to be evicted early.
agingade
requested review from
dschneider-pivotal,
kirklund,
lgallinat,
nreich and
pivotal-eshu
dschneider-pivotal
approved these changes
Dec 12, 2017
nreich
approved these changes
Dec 12, 2017
PivotalSarge
pushed a commit
to upthewaterspout/geode
that referenced
this pull request
Dec 14, 2017
* GEODE-3869: Fix early eviction. While code review found that the refactoring moved "evictionNode.unsetRecentlyUsed()" to "appendEntry()" which gets call by other places (adding entry into the list); this causes the recently used entry to be evicted early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While code review found that the refactoring moved "evictionNode.unsetRecentlyUsed()" to
"appendEntry()" which gets call by other places (adding entry into the list); this causes
the recently used entry to be evicted early.