Skip to content

GEODE-4092 New protocol does not have an API to get the best server t…#1210

Closed
bschuchardt wants to merge 1 commit intodevelopfrom
feature/GEODE-4092
Closed

GEODE-4092 New protocol does not have an API to get the best server t…#1210
bschuchardt wants to merge 1 commit intodevelopfrom
feature/GEODE-4092

Conversation

@bschuchardt
Copy link
Copy Markdown
Contributor

…o connect to

GetAllAvailableServers has been replaced by GetServer. The handler uses
the ServerLocator's processRequest API to ensure we have the same
functionality as existing non-protobuf locator request handling.

If a server isn't found we are returning Success with a null server
location. Should this be changed to return an error code?

@upthewaterspout @WireBaron @PivotalSarge @galen-pivotal

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

…o connect to

GetAllAvailableServers has been replaced by GetServer.  The handler uses
the ServerLocator's processRequest API to ensure we have the same
functionality as existing non-protobuf locator request handling.

If a server isn't found we are returning Success with a null server
location.  Should this be changed to return an error code?
Copy link
Copy Markdown
Contributor

@PivotalSarge PivotalSarge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschuchardt
Copy link
Copy Markdown
Contributor Author

commit cadecc2 (HEAD -> develop, origin/develop)
Author: Bruce Schuchardt bschuchardt@pivotal.io
Date: Tue Jan 2 14:26:52 2018 -0800

GEODE-4092 New protocol does not have an API to get the best server to connect to

GetAllAvailableServers has been replaced by GetServer.  The handler uses
the ServerLocator's processRequest API to ensure we have the same
functionality as existing non-protobuf locator request handling.

If a server isn't found we are returning Success with a null server
location.  Should this be changed to return an error code?

@bschuchardt bschuchardt closed this Jan 2, 2018
@bschuchardt bschuchardt deleted the feature/GEODE-4092 branch August 10, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants