GEODE-4146: fix XmlEntity matching for JdbcConnectorService#1215
Merged
kirklund merged 2 commits intoapache:developfrom Jan 3, 2018
Merged
Conversation
JdbcClusterConfigDistributedTest exposes the failure and confirms the fix.
kirklund
requested review from
agingade,
dschneider-pivotal,
lgallinat,
nreich and
pivotal-eshu
dschneider-pivotal
approved these changes
Jan 2, 2018
|
Fails rat (missing copyright notice) and spotless: once fixed, I approve of the changes. |
nreich
approved these changes
Jan 2, 2018
agingade
reviewed
Jan 3, 2018
| XmlEntity createXmlEntity(FunctionContext<?> context) { | ||
| return new XmlEntity(createCacheProvider(context), CACHE, PREFIX, NAMESPACE, | ||
| CONNECTION_SERVICE.getTypeName()); | ||
| CONNECTION_SERVICE.getTypeName(), NAME, CONNECTION_SERVICE.getTypeName()); |
There was a problem hiding this comment.
This is confusing, are we saying the parent and child types are same?
Contributor
Author
There was a problem hiding this comment.
Yes. XmlEntity has a flawed and confusing design. Someone needs to redo that class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JdbcConnectorService usage of XmlEntity was resulting in multiple jdbc connector service elements being written to cluster config. This then results in already exists exceptions during startup.
JdbcClusterConfigDistributedTest reproduced the problem we saw during manual testing and verifies the fix.