Skip to content

GEODE-4255: Remove mandatory failure on macOS.#1254

Merged
upthewaterspout merged 1 commit intoapache:developfrom
PivotalSarge:feature/GEODE-4255
Jan 11, 2018
Merged

GEODE-4255: Remove mandatory failure on macOS.#1254
upthewaterspout merged 1 commit intoapache:developfrom
PivotalSarge:feature/GEODE-4255

Conversation

@PivotalSarge
Copy link
Contributor

Since GatewayReceiverImpl uses a much less brittle string comparison now, the case that this mandatory failure was trying to avoid no longer exists.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • [n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

@jhuynh1 @nabarunnag

Copy link
Contributor

@jhuynh1 jhuynh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will try to run this and merge when I get the chance

@PivotalSarge
Copy link
Contributor Author

PivotalSarge commented Jan 9, 2018 via email

@upthewaterspout upthewaterspout merged commit a4329ad into apache:develop Jan 11, 2018
@PivotalSarge PivotalSarge deleted the feature/GEODE-4255 branch January 26, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants